Fixed comment for connect() return. #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent connect() does not return the server id. It returned the number of servers we should connect to.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign @justinsb as he flagged it. |
|
/assign @justinsb |
justinsb
reviewed
Jan 29, 2025
| // Connect makes the grpc dial to the proxy server. It returns the serverID | ||
| // it connects to. | ||
| // Connect makes the grpc dial to the proxy server. It returns the count | ||
| // of the number of servers this agent should connected to. |
There was a problem hiding this comment.
Sorry to nit pick, but:
Suggested change
| // of the number of servers this agent should connected to. | |
| // of the number of servers this agent should connect to. |
(Feel free to just make the change locally and repush, it's just as easy as accepting, rebasing etc; if that's what we do in this repo)
|
Actually I think I'm going to go through and add lots of comments around serverCount, so let's just merge regardless of my nit. /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agent connect() does not return the server id.
It returned the number of servers we should connect to.