Add DisableSSLSessionResumption field in PostgresVersion CRD #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| type PostgresVersionTLSSpec struct { | ||
| // DisableSSLSessionResumption determines whether to disable or enable Envoy Session Resumption | ||
| // +optional | ||
| DisableSSLSessionResumption *bool `json:"disableSSLSessionResumption,omitempty"` |
There was a problem hiding this comment.
I think we don't need pointer for bool
There was a problem hiding this comment.
Yes updated. As we are going to have false as default.
There was a problem hiding this comment.
and DisableSessionResumption is enough
Signed-off-by: souravbiswassanto <saurov@appscode.com>
souravbiswassanto
force-pushed
the
pg-disable-tls-resumption
branch
from
81c3b80 to
d30f38b
Compare
shiponcs
suggested changes
Feb 5, 2025
| type PostgresVersionTLSSpec struct { | ||
| // DisableSSLSessionResumption determines whether to disable or enable Envoy Session Resumption | ||
| // +optional | ||
| DisableSSLSessionResumption bool `json:"disableSSLSessionResumption,omitempty"` |
There was a problem hiding this comment.
The convention is to call it "stateful session resumption".
Can we reflect the keyword—"stateful" in this variable name?
ref: rfc5077
ArnobKumarSaha
approved these changes
Feb 5, 2025
ArnobKumarSaha
pushed a commit
that referenced
this pull request
Feb 5, 2025
Signed-off-by: souravbiswassanto <saurov@appscode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.