Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Create Taj Button variants #552

Merged
merged 1 commit into from
Jan 21, 2025
Merged

UI: Create Taj Button variants #552

merged 1 commit into from
Jan 21, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 19, 2025

TL;DR

Introduced several new composable button variants with customizable styles and dimensions to enhance UI consistency and reusability.

What changed?

  • Added Button component with customizable colors and dimensions
  • Introduced SubtleButton with a light background color
  • Added TextButton with a transparent background and text color
  • Introduced AlertButton with an alert background color
  • Provided ButtonDefaults object for default color schemes and dimension configurations
  • Added ButtonDimensions data class for button sizing and padding

Why make this change?

To provide a more consistent and maintainable button system across the application. This change enhances component reusability, reduces code duplication, and standardizes button styles and dimensions.

@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 19, 2025 13:23
@ksharma-xyz ksharma-xyz force-pushed the 01-18-create_alertbutton branch from 51c1239 to 45cdbf8 Compare January 20, 2025 08:30
@ksharma-xyz ksharma-xyz changed the title Ideal button UI: Create Taj Button Jan 20, 2025
@ksharma-xyz ksharma-xyz changed the title UI: Create Taj Button UI: Create Taj Button variants Jan 20, 2025
@ksharma-xyz ksharma-xyz added the UI Design System Related changes label Jan 20, 2025
@ksharma-xyz ksharma-xyz added this to the 1.0.6 milestone Jan 20, 2025
@ksharma-xyz ksharma-xyz changed the base branch from 01-18-create_alertbutton to graphite-base/552 January 20, 2025 11:57
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/552 to main January 20, 2025 11:58
@ksharma-xyz ksharma-xyz merged commit b2ae744 into main Jan 21, 2025
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 01-19-ideal_button branch January 21, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Design System Related changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant