-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Analytics: Rename transportMode to themeId in theme selection event (#…
…593) ### TL;DR Updated theme selection analytics to track theme IDs instead of transport modes ### What changed? - Renamed `transportMode` parameter to `themeId` in `ThemeSelectedEvent` - Simplified theme selection tracking by removing transport mode conversion - Updated corresponding test cases to reflect the new parameter name ### How to test? 1. Navigate to theme selection screen 2. Select different themes 3. Verify analytics events are logged with theme IDs 4. Run unit tests to confirm analytics tracking behavior ### Why make this change? Tracking raw theme IDs provides more accurate analytics data compared to converting them to transport modes, which may not always have a direct mapping. This change simplifies the analytics implementation and makes it more maintainable.
- Loading branch information
1 parent
a266f22
commit a5c1b99
Showing
5 changed files
with
8 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters