Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default number of threads to 1 #403

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Set default number of threads to 1 #403

merged 2 commits into from
Mar 6, 2024

Conversation

marcelm
Copy link
Collaborator

@marcelm marcelm commented Mar 4, 2024

Also, adjusted logging output to make it more obvious how many threads are used (and which mode). Example:

...
Total time indexing: 3.79 s
Processing paired-end reads in mapping-only mode using 1 worker thread
 Mapped         1.00 M reads @    11.02 us/read
Done!

Other example messages:

Processing single-end reads in abundance estimation mode using 4 worker threads
...
Processing single-end reads using 4 worker threads

Closes #401

Also, adjusted logging output to make it more obvious how many threads are
used (and which mode). Example:

```
...
Total time indexing: 3.79 s
Processing paired-end reads in mapping-only mode using 1 worker thread
 Mapped         1.00 M reads @    11.02 us/read
Done!
```
Other possible messages:
```
Processing single-end reads in abundance estimation mode using 4 worker threads
...
Processing single-end reads using 4 worker threads
```

Closes #401
@ksahlin
Copy link
Owner

ksahlin commented Mar 5, 2024

Great! About your comment on making it 'easily interpretable' for less experienced users (#401); what do you think about removing 'worker' in 1 worker thread and just state using 1 thread?

One may think that worker threads are not directly related to number of threads the program is using. For example, in the producer/consumer solution there is one producer and several consumers that sometimes might be confused with 'workers'.

@marcelm
Copy link
Collaborator Author

marcelm commented Mar 5, 2024

One may think that worker threads are not directly related to number of threads the program is using.

I somehow misremembered that the main thread does the I/O, so it was actually my intention to convey that there are more than $n$ threads, but checking the code, I see that that isn’t the case: The main thread only prints the progress indicator, so it shouldn’t be counted. I have changed the text as you suggested.

@ksahlin
Copy link
Owner

ksahlin commented Mar 6, 2024

Great, approved!

@marcelm marcelm merged commit 64dee19 into main Mar 6, 2024
9 checks passed
@marcelm marcelm deleted the one-thread branch March 6, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default number of threads
2 participants