Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add GitHub Actions workflow for building and publishing #241

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

a-hilaly
Copy link
Member

This workflow:

  • Builds container images using ko
  • Publishes images to GitHub Container Registry on main branch pushes
  • Publishes both container images and Helm charts on tag releases
  • Only builds images (no push) for pull requests

Copy link
Contributor

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Amine 🎉 Github Actions FTW
/lgtm

This workflow:
- Builds container images using ko
- Publishes images to GitHub Container Registry on main branch pushes
- Publishes both container images and Helm charts on tag releases
- Only builds images (no push) for pull requests
@@ -84,7 +84,7 @@ export KRO_VERSION=<new-version>

Upgrade the controller
```
helm upgrade kro oci://public.ecr.aws/kro/kro \
helm upgrade kro oci://ghcr.io/a-hilaly/kro/kro \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kro-run ?

matthchr
matthchr previously approved these changes Jan 30, 2025
sed -i "s/version: .*/version: ${RELEASE_VERSION}/" helm/Chart.yaml
sed -i "s/appVersion: .*/appVersion: \"${RELEASE_VERSION}\"/" helm/Chart.yaml
helm package helm
HELM_IMAGE=ghcr.io/${{ github.repository }} make publish-helm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: newline at EOF?

@barney-s barney-s merged commit 1f4142a into kro-run:main Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants