-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add GitHub Actions workflow for building and publishing #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Amine 🎉 Github Actions FTW
/lgtm
This workflow: - Builds container images using ko - Publishes images to GitHub Container Registry on main branch pushes - Publishes both container images and Helm charts on tag releases - Only builds images (no push) for pull requests
c77f455
to
d2ab505
Compare
513f9df
to
db96594
Compare
@@ -84,7 +84,7 @@ export KRO_VERSION=<new-version> | |||
|
|||
Upgrade the controller | |||
``` | |||
helm upgrade kro oci://public.ecr.aws/kro/kro \ | |||
helm upgrade kro oci://ghcr.io/a-hilaly/kro/kro \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kro-run ?
sed -i "s/version: .*/version: ${RELEASE_VERSION}/" helm/Chart.yaml | ||
sed -i "s/appVersion: .*/appVersion: \"${RELEASE_VERSION}\"/" helm/Chart.yaml | ||
helm package helm | ||
HELM_IMAGE=ghcr.io/${{ github.repository }} make publish-helm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: newline at EOF?
e7a647d
to
d511295
Compare
This workflow: