Add GCP CloudSQL example #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barney-s
changed the title
a-hilaly
previously approved these changes
Jan 28, 2025
barney-s
force-pushed
the
gcp-cloudsql
branch
3 times, most recently
from
ada15ee to
71df947
Compare
barney-s
changed the title
barney-s
force-pushed
the
gcp-cloudsql
branch
2 times, most recently
from
3fcdfc3 to
d88743d
Compare
|
Causes #225 |
barney-s
force-pushed
the
gcp-cloudsql
branch
from
d88743d to
5da8156
Compare
justinsb
reviewed
Jan 29, 2025
examples/gcp/cloud-sql/rg.yaml
Outdated
| name: iam-enablement | ||
| spec: | ||
| resourceID: iam.googleapis.com | ||
| - id: servceusageEnable |
There was a problem hiding this comment.
It would also be nice to make this optional, one less thing to worry about when writing a template. Obviously we couldn't refer to "unnamed variables" ... but maybe it is important for a stable status?
barney-s
force-pushed
the
gcp-cloudsql
branch
from
5da8156 to
1998442
Compare
|
This is verified on latest with explicit dependencies added. Works. Ready for review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has a primary and single replica.
source: https://github.com/GoogleCloudPlatform/k8s-config-connector/tree/master/experiments/compositions/samples/CloudSQL/composition