Fix bug where emit with brackets caused an excception (#619)

This bug was introduced when taking the last name of a property chain as tha name of the column.
koralium · Nov 28, 2024 · e2afe30 · e2afe30 · github-actions · Nov 28, 2024
1 parent 6eebdb7
commit e2afe30
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/FlowtideDotNet.Substrait/Sql/EmitData.cs b/src/FlowtideDotNet.Substrait/Sql/EmitData.cs
@@ -233,8 +233,16 @@ public bool TryGetEmitIndex(
                             seg = newSegment;
                         }
 
-                        var lastIdentifier = mapIdentifiers.Last();
-                        name = lastIdentifier; // Use the last identifier as name
+                        if (mapIdentifiers.Count > 0)
+                        {
+                            var lastIdentifier = mapIdentifiers.Last();
+                            name = lastIdentifier; // Use the last identifier as name
+                        }
+                        else
+                        {
+                            name = GetName(emitInfoPartial.Index[0]);
+                        }
+
 
                         // TODO: For now we just return any type, but we should try to find the correct type
                         type = new AnyType();

diff --git a/tests/FlowtideDotNet.AcceptanceTests/SelectTests.cs b/tests/FlowtideDotNet.AcceptanceTests/SelectTests.cs
@@ -27,6 +27,15 @@ public async Task SelectOneColumnsWithoutId()
             AssertCurrentDataEqual(Users.Select(x => new { x.FirstName }));
         }
 
+        [Fact]
+        public async Task SelectOneColumnsWithTableAliasAndBrackets()
+        {
+            GenerateData();
+            await StartStream("INSERT INTO output SELECT u.[firstName] FROM users u");
+            await WaitForUpdate();
+            AssertCurrentDataEqual(Users.Select(x => new { x.FirstName }));
+        }
+
         [Fact]
         public async Task SelectOneColumnsWithoutIdAndUpdate()
         {
Benchmark suite	Current: `e2afe30`	Previous: `7db1083`	Ratio
`FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.InnerJoin`	`547547330` ns (`± 9806962.326389462`)	`588638700` ns (`± 9231369.002121696`)	`0.93`
`FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.LeftJoin`	`643246000` ns (`± 26235090.261041604`)	`632393477.7777778` ns (`± 23156158.76418074`)	`1.02`
`FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ProjectionAndNormalization`	`205533750` ns (`± 15728424.213947464`)	`171268600` ns (`± 6644227.006958748`)	`1.20`
`FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.SumAggregation`	`215746200` ns (`± 10021434.508758381`)	`190822830` ns (`± 6415026.852121856`)	`1.13`
`FlowtideDotNet.Benchmarks.Stream.StreamBenchmark.ListAggWithMapAggregation`	`2370286230` ns (`± 119160366.21019077`)	`2656394200` ns (`± 136074715.58524996`)	`0.89`