Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: http probe downgrades from http2 to http1 when it encounters an error #15436

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

fix: retry the options request until a probe succeeds for a protocol

cd205ce
Select commit
Loading
Failed to load commit list.
Open

[WIP] fix: http probe downgrades from http2 to http1 when it encounters an error #15436

fix: retry the options request until a probe succeeds for a protocol
cd205ce
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 1, 2025 in 1s

84.66% (target 80.00%)

View this Pull Request on Codecov

84.66% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (222065d) to head (cd205ce).
Report is 186 commits behind head on main.

Files with missing lines Patch % Lines
pkg/queue/health/probe.go 25.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15436      +/-   ##
==========================================
+ Coverage   84.54%   84.66%   +0.11%     
==========================================
  Files         219      219              
  Lines       13595    13600       +5     
==========================================
+ Hits        11494    11514      +20     
+ Misses       1734     1710      -24     
- Partials      367      376       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov