Reevaluate table and header position and height when needed #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reevalute the table height and position on scroll. This helps with dom changes such as showing/hiding an element or filtering a table.
|
Thanks for your awesome library! I thought you might like this small addition I'm using for a page that changes as the user filters the table or hides/reveals some elements. |
- Move table header position and size evaluation to function - Reevaluate on page resize - Reevalute on scroll if the body height has changed
HarlemSquirrel
changed the title
added 2 commits
March 1, 2018 14:05
- Fix th widths - Use spaces instead of tabs for indentation
Account for other scripts that might set header width attr
HarlemSquirrel
force-pushed
the
dynamic-page-size
branch
from
0bfd5df to
78b3701
Compare
added 3 commits
March 20, 2018 17:33
- Set header classes on click to account for sorting scripts etc. - Remove unneeded comment - Simplify no_fixed_support
Use a global constant with a run() function so we can call this from other scripts such as a `turbolinks:load` event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with dom changes such as showing/hiding an element or filtering a table and with window resizing.