Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group accounts #333

Closed
kieranroneill opened this issue Oct 1, 2024 · 2 comments · Fixed by #343
Closed

Group accounts #333

kieranroneill opened this issue Oct 1, 2024 · 2 comments · Fixed by #343
Assignees
Labels
✨ feature New feature or request
Milestone

Comments

@kieranroneill
Copy link
Member

Summary

Grouping accounts seems like a no-brainer type feature for AVM wallets as accounts are intrinsically linked. For example, an account can be re-keyed and keeping the this and the auth account in the same group is a definite use case.

Acceptance Criteria

Scenario 1 User creates a group for an account
GIVEN no groups exist
WHEN the User presses "Add To Group"
AND the User enters the group name
THEN the account is added to the group
Scenario 2 User creates a group for an account
GIVEN a group of accounts exist
WHEN the User presses "Add To Group"
AND the User selects the group from the list
THEN the account is added to the group
Scenario 3 User removes the account from the group
GIVEN an account is part of a group
WHEN the User presses "Remove From Group"
THEN the account is removed from the group
@kieranroneill kieranroneill self-assigned this Oct 1, 2024
@kieranroneill kieranroneill converted this from a draft issue Oct 1, 2024
@kieranroneill kieranroneill added the ✨ feature New feature or request label Oct 1, 2024
@kieranroneill kieranroneill added this to the v2.4.0 milestone Oct 1, 2024
@kieranroneill kieranroneill moved this to 🔖 Ready in Web Extension Oct 17, 2024
@lancoer
Copy link

lancoer commented Nov 12, 2024

Good morning @kieranroneill
Is deadline remaining 6 days for this?

@kieranroneill
Copy link
Member Author

kieranroneill commented Nov 12, 2024

Good morning @kieranroneill Is deadline remaining 6 days for this?

Good morning!

Sorry, this deadline had to be bumped up until this week. I have been swamped with Kibisis mobile and some alpha Kibisis NFT work 😅

I will hopefully finish this today and release version 2.4.0 tomorrow 😄

@kieranroneill kieranroneill linked a pull request Nov 16, 2024 that will close this issue
11 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Web Extension Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants