Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: group accounts #343

Merged
merged 28 commits into from
Nov 16, 2024
Merged

feat: group accounts #343

merged 28 commits into from
Nov 16, 2024

Conversation

kieranroneill
Copy link
Member

Description

  • Add new IAccountGroup type.
  • Add groups to accounts slice.
  • Add groupID and groupIndex to IAccount objects.
  • Add modal to add account group.
  • Move common code to a new ActionItem component.
  • Add groups to SideBar.
  • Add functionality to add and remove accounts from groups.
  • Implement re-ordering of groups.
  • Implement re-ordering accounts in groups.
  • Add SideBar button to manage groups through the ManageGroupsModal.
    • Implement adding new groups.
    • Implement removing groups.
    • Implement renaming groups.
  • Add EditableText component.

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

kieranroneill and others added 26 commits October 2, 2024 20:25
@kieranroneill
feat: add account group type
14d59f6
@kieranroneill
feat: add account group repository
595ee15
@kieranroneill
feat: add account group to accounts slice
43b3cef
@kieranroneill
feat: implement add/remove account group to account page overflow menu
0948e68
@kieranroneill
chore: merge origin/beta
3072423
@kieranroneill
chore: squash
b60631c
@kieranroneill
chore: merge origin/beta
b2ff844
@kieranroneill
chore: merge origin/beta
eace878
@kieranroneill
ci: add pr title validation
740b49b
@kieranroneill
feat: add convert to kebab case utility function
fb4679b
@kieranroneill
feat: add save account group thunk
10cf9c3
@kieranroneill
feat: add action item component
71a987b
@kieranroneill
feat: add add to group modal
e248c87
@kieranroneill
feat: add index to group and add group item
14715b8
@kieranroneill
feat: add collapsible to groups
f5826a5
@kieranroneill
refactor: separate group list into a separate component
e5e20f4
@kieranroneill
feat: allow re-ordering accounts in group
94d259d
@kieranroneill
fix: allow groups to be correctly sorted
54a2906
@kieranroneill
feat: add move group option on account
26255a9
@kieranroneill
feat: add group badges to account page
65876cc
@kieranroneill
feat: add number of account in group badge
4200c3c
@kieranroneill
chore: squash
9a4af69
@kieranroneill
feat: add button to add an account to a group
3bb2e50
@kieranroneill
refactor: move move group modal to global modal and controlled by redux
5dc6fde
@kieranroneill
feat: add modal to edit groups
a09a9e3
@kieranroneill
feat: add editable text component and allow editing group names
6bcee75
@kieranroneill kieranroneill linked an issue Nov 16, 2024 that may be closed by this pull request
Group accounts #333
Closed
@kieranroneill kieranroneill self-assigned this Nov 16, 2024
@kieranroneill kieranroneill added ♻️ refactor The refactoring fairy has waved their magic wand ✨ feature New feature or request labels Nov 16, 2024
@kieranroneill kieranroneill added the 📦 dependencies New dependencies label Nov 16, 2024
@kieranroneill kieranroneill merged commit 28dc915 into beta Nov 16, 2024
8 checks passed
@kieranroneill kieranroneill deleted the 333-group-accounts branch November 16, 2024 19:30
github-actions bot pushed a commit that referenced this pull request Nov 16, 2024
@kibi-bot
chore(release): 2.4.0-beta.5
a8cbc2a 
# [2.4.0-beta.5](v2.4.0-beta.4...v2.4.0-beta.5) (2024-11-16)

### Features

* group accounts ([#343](#343)) ([28dc915](28dc915))
@kibi-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.4.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kibi-bot kibi-bot added the 🚀 released To the moon! label Nov 16, 2024
github-actions bot pushed a commit that referenced this pull request Nov 16, 2024
@kibi-bot
chore(release): 2.4.0
7969090 
# [2.4.0](v2.3.2...v2.4.0) (2024-11-16)

### Features

* change icon of account ([#335](#335)) ([0174529](0174529))
* group accounts ([#343](#343)) ([28dc915](28dc915))
* render markdown for whats new ([#344](#344)) ([4376081](4376081))
* switch to new voi testnet ([#342](#342)) ([a31c253](a31c253))
@kibi-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kieranroneill kieranroneill

Labels
📦 dependencies New dependencies ✨ feature New feature or request ♻️ refactor The refactoring fairy has waved their magic wand 🚀 released To the moon!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group accounts
2 participants
@kieranroneill @kibi-bot