-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
so agile: More UI Overhaul Progress on Container Sheet, plus refactors #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-overhaul-episode-2
…-overhaul-episode-2
…-overhaul-episode-2
…oter. Added stub mini capacity bar. Moved application closure before the unmounting of components.
…e-sheet-2 into ui-overhaul-episode-2
Added windowContent public getter on svelte mixin. Made .window-content relatively positioned. Commented temporarily broken mini bar. Added showable-hideable item name to header start. Documented coalesce function.
…the gap it is taking up.
… of a rote CSS Grid column string. Updated all callers. Cleaned up stray loggers.
…lidate behaviors and reduce rote usage of the IntersectionObserver.
…r contents section.
…-overhaul-episode-2
…-overhaul-episode-2
…-overhaul-episode-2
…-overhaul-episode-2
…e-sheet-2 into ui-overhaul-episode-2
…-overhaul-episode-2
…e-sheet-2 into ui-overhaul-episode-2
Added currency context to the container context. Added inverse input styles for some inputs as needed. Refined pill styles for list item elements.
When whitespace, Save Changes just closes the dialog.
Still needs to be dressed up a little.
…in TidyFlags. Styled up the def custom sections config to match the local aesthetic. Minor style adjustments.
…-overhaul-episode-2
Applied labels to all section selector buttons.
Restructured setting data to nest tabs within sheet types. Revamped setting screen to match new data structure.
Reworked the wording and layout for global custom section settings.
…s applied to a global custom section.
…-overhaul-episode-2
…m sections. Generalized the spellbook tab ID.
Wired up NPC ability global custom sections. Made spellbook wire-up tab-aware so that PCs can register sections in the Attributes tab separate from the Spellbook / Features / etc. tabs.
…es with default exports. Made tab maps that key on Tab ID and are reactive / derived from the stateful tab array. Trimmed down custom section "Show When Empty" filters to just the ones that are actually implemented. Removed functionality from favorites.
Removed mention of folder form the create data for container item creation prompt when owned by an actor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made lots of unspecified progress on the UI overhaul.