-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1] Native Actions List in Tidy 5e Sheets #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a Features settings tab to Sheet Settings. Added Actions List settings UI to Features settings tab. Added English localization fields for Actions list and Features settings tab.
Wired actions list settings to register/unregister the actor tabs according to settings. Removed unused code.
…pha-1-actor-actions-tab
…ndled with default tab selection. Removed unused Actions localization content. Moved ActorJournalTab to the actor/tabs directory. Added the Actions tab to the sheet state for each actor type so that it is available in tab selection.
Added ActorActions type to the core ActorSheetContext type. Updated each actor type to pull actor actions during data setup.
Added scroll container to actions tab. Aligned ItemUseButton to be centered vertically, in preparation for multi-line item table rows.
Added image size overrride that applies to ItemUseButton and ItemImage components and is based on a CSS variable, falling back to the usual 1.5rem.
Added "Other" to the activation type labels.
…nts. Extracted RechargeControl and replaced all the places where it'd been copy/pasted throughout development.
…abilities, and vehicle attributes tabs. Added "Shift+Click to clear override" functionality. Added some null-safety to the actions tab prop checking. Added localization keys.
Added useActionsFeature boolean to all actor sheet contexts. Limited presence of action filter override control to when useActionsFeature is true. Added Action Filter Override and Clear Override options to context menu.
…tracted out of components. Added script for determining the item info card to use. Streamlined item info card template selection by delegating default fallback to the new function during rendering rather than during the delay period. Removed explicit item card template assignment by the various lists and grids, allowing the item type to determine the card template instead. Indirectly got item cards on the Action tab.
Stacked item use text so that the numbers are on top and the small text is on bottom. Set up flex-wrap for the damage strings and make them not truncate. Given enough damage types, the row will expand to accommodate them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1