add log tests for test_kselftest parser #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padovan
reviewed
Feb 3, 2025
| }, | ||
| { | ||
| "error_summary": "Direct firmware load for rtl_nic/rtl8168h-2.fw failed with error -2", | ||
| "error_type": "linux.kernel.error_return_code" |
There was a problem hiding this comment.
they repeat several times in the log
| "error_type": "linux.kernel.error_return_code" | ||
| }, | ||
| { | ||
| "error_summary": "not ok 1 selftests: exec: execveat # exit=1", |
There was a problem hiding this comment.
I wonder what 1 means in "not ok 1 selfests"
There was a problem hiding this comment.
this is output of kselftest, maybe @musamaanjum could shed a light?
There was a problem hiding this comment.
One kselftest can have several sub-tests or sub-test cases in it. 1 here just means that this is the output of the first test case from the test. This number is usually meanigless and only helps somewhat when we want to debug the failure. If its possible, just ignore this number.
add a log test to be executed when ./run_tests.sh Signed-off-by: Helen Koike <helen.koike@collabora.com>
execute it on push and on pull requests Signed-off-by: Helen Koike <helen.koike@collabora.com>
fix:
/home/runner/work/logspec/logspec/logspec/errors/linux_kernel.py:127: SyntaxWarning: invalid escape sequence '\d'
start_marker_regex = f'{LINUX_TIMESTAMP} .*?error -\d+.*?'
Signed-off-by: Helen Koike <helen.koike@collabora.com>
index is out dated, update it with all the logs that were recently added. Signed-off-by: Helen Koike <helen.koike@collabora.com>
helen-fornazier
force-pushed
the
kselftest2
branch
from
1127067 to
a2eb303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kselftest parser was added but tests were missing, add the tests and update the test indexes