feat(issues-list): add tag 'new' #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilx
force-pushed
the
feat/new-issue-tag
branch
2 times, most recently
from
0ef281a to
2f3514b
Compare
murilx
force-pushed
the
feat/new-issue-tag
branch
from
2f3514b to
eb5ebd5
Compare
murilx
force-pushed
the
feat/new-issue-tag
branch
from
eb5ebd5 to
6ce925d
Compare
MarceloRobert
approved these changes
Feb 14, 2025
| @@ -196,6 +197,7 @@ export const messages = { | |||
| 'hardwareDetails.treeBranch': 'Tree / Branch', | |||
| 'issue.alsoPresentTooltip': 'Issue also present in {tree}', | |||
| 'issue.firstSeen': 'First seen', | |||
| 'issue.newIssue': 'This issue is new to this tree', | |||
There was a problem hiding this comment.
The meaning of the "new" tag is not just "to this tree",
Suggested change
| 'issue.newIssue': 'This issue is new to this tree', | |
| 'issue.newIssue': 'This is the first time this issue was seen', |
You can think of a tooltip that's better than my suggestion, but something along those lines
- Changed the issuesExtra response to include more info about the first incident of each issue, including commit hash, git branch and git url - Added the pill to the issue list if the commit hash of the first incident is the same commit hash of the tree details page Closes #571
murilx
force-pushed
the
feat/new-issue-tag
branch
from
6ce925d to
fb07e54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #571
How to test
You can verify if an issue is really new if when you open its issue details there's only one test/build
Visual reference
http://localhost:5173/tree/f5d74f9f7c3b2495596b43c01f5747b66c8ef70d?ti%7Cc=v6.9-12136-gf5d74f9f7c3b&ti%7Cch=f5d74f9f7c3b2495596b43c01f5747b66c8ef70d&ti%7Cgb=nvme-rx-offload-v25&ti%7Cgu=https%3A%2F%2Fgithub.com%2Faaptel%2Flinux.git&ti%7Ct=aaptel
http://localhost:5173/tree/4dc1d1bec89864d8076e5ab314f86f46442bfb02?iv=1&p=bt&ti%7Cc=v6.14-rc2-41-g4dc1d1bec8986&ti%7Cch=4dc1d1bec89864d8076e5ab314f86f46442bfb02&ti%7Cgb=master&ti%7Cgu=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&ti%7Ct=mainline
