Feat: show issueExtraDetails data on treeDetails #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarceloRobert
force-pushed
the
feat/more-issue-info-FE
branch
2 times, most recently
from
f53d62c to
7248507
Compare
murilx
reviewed
Feb 12, 2025
murilx
reviewed
Feb 12, 2025
WilsonNet
reviewed
Feb 12, 2025
dashboard/src/types/issueExtras.ts
Outdated
Comment on lines
4
to
8
| enum PossibleIssueTags { | ||
| Mainline = 'mainline', | ||
| Stable = 'stable', | ||
| LinuxNext = 'linux-next', | ||
| } |
There was a problem hiding this comment.
https://dev.to/ivanzm123/dont-use-enums-in-typescript-they-are-very-dangerous-57bh
Suggested change
| enum PossibleIssueTags { | |
| Mainline = 'mainline', | |
| Stable = 'stable', | |
| LinuxNext = 'linux-next', | |
| } | |
| const PossibleIssueTags = { | |
| mainline: 'mainline', | |
| stable: 'stable', | |
| linuxNext : 'linux-next', | |
| } as const |
WilsonNet
reviewed
Feb 12, 2025
| @@ -150,6 +140,19 @@ const BuildTab = ({ treeDetailsLazyLoaded }: BuildTab): JSX.Element => { | |||
| diffFilter={diffFilter} | |||
| /> | |||
| </div> | |||
| <MemoizedIssuesList | |||
| title={<FormattedMessage id="global.issues" />} | |||
| issues={treeDetailsData.buildsIssues || []} | |||
There was a problem hiding this comment.
nit
Suggested change
| issues={treeDetailsData.buildsIssues || []} | |
| issues={treeDetailsData.buildsIssues ?? []} |
WilsonNet
reviewed
Feb 12, 2025
Comment on lines
+26
to
+31
| issuesExtras: { | ||
| data?: IssueExtraDetailsResponse; | ||
| isLoading: boolean; | ||
| status: QuerySelectorStatus; | ||
| error: UseQueryResult['error']; | ||
| }; |
There was a problem hiding this comment.
nit: you can add a generic type
type TypeName = <T> {
data?: T;
isLoading: boolean;
status: QuerySelectorStatus;
error: UseQueryResult['error'];
};
type IssueExtrar = TypeName<IssueExtraDetailsResponse>
WilsonNet
reviewed
Feb 12, 2025
dashboard/src/api/issueExtras.ts
Outdated
| }: ITabsIssues): IssueKeyList => { | ||
| const result: IssueKeyList = []; | ||
|
|
||
| for (const issue of buildIssues || []) { |
There was a problem hiding this comment.
buildIssues.forEach...
WilsonNet
reviewed
Feb 12, 2025
dashboard/src/api/issueExtras.ts
Outdated
| for (const issue of buildIssues || []) { | ||
| result.push([issue.id, issue.version]); | ||
| } | ||
| for (const issue of bootIssues || []) { |
WilsonNet
reviewed
Feb 12, 2025
dashboard/src/api/issueExtras.ts
Outdated
| for (const issue of bootIssues || []) { | ||
| result.push([issue.id, issue.version]); | ||
| } | ||
| for (const issue of testIssues || []) { |
MarceloRobert
force-pushed
the
feat/more-issue-info-FE
branch
from
7248507 to
8a2d715
Compare
murilx
approved these changes
Feb 13, 2025
MarceloRobert
force-pushed
the
feat/more-issue-info-FE
branch
from
8a2d715 to
013e746
Compare
MarceloRobert
force-pushed
the
feat/more-issue-info-FE
branch
from
013e746 to
ae109d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
Go to any treeDetails that have issues; all of them should have at least the first_seen information, the tags are optional and depend on each issue in particular.
Examples are sashal-next/linus-next, stable/linux-6.6.y and android/android12-5.10-lts.
You can check every tree that the issues are present by looking in the network tab of dev tools and see the response for the /issue/extras/ request.
Reference (from stabe/linux-6.6.y):
Closes #870