feat: add status icon to details header #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonNet
reviewed
Feb 12, 2025
| variant, | ||
| }: { | ||
| className?: string; | ||
| variant?: string | boolean; |
There was a problem hiding this comment.
Status (from types/database) | boolean
There was a problem hiding this comment.
now that we have pydantic we can guarantee that is a literal
WilsonNet
reviewed
Feb 12, 2025
| variant?: string | boolean; | ||
| }): JSX.Element => { | ||
| return match(variant) | ||
| .with(P.union('PASS', true), _ => ( |
murilx
force-pushed
the
feat/details-header-status
branch
from
8404154 to
d372cb2
Compare
murilx
force-pushed
the
feat/details-header-status
branch
from
d372cb2 to
6b3e8da
Compare
MarceloRobert
approved these changes
Feb 12, 2025
murilx
force-pushed
the
feat/details-header-status
branch
from
6b3e8da to
7dfe38f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #895
Visual Reference
Pass
http://localhost:5173/test/maestro%3A67aa5897b27a1f56cc36ee53?ls=10&p=t&ti%7Cc=v6.9-12136-gf5d74f9f7c3b&ti%7Cch=f5d74f9f7c3b2495596b43c01f5747b66c8ef70d&ti%7Cgb=nvme-rx-offload-v25&ti%7Cgu=https%3A%2F%2Fgithub.com%2Faaptel%2Flinux.git&ti%7Ct=aaptel
Fail
http://localhost:5173/test/maestro%3A67a861e8661a7bc874947206?et=1739214000&iv=1&p=bt&st=1738782000&tf%7Cb=a&tf%7Cbt=f&tf%7Ct=a
Inconclusive
http://localhost:5173/test/maestro%3A67aa5acdb27a1f56cc36f15b?p=t&tf%7Cb=a&tf%7Cbt=a&tf%7Ct=i&ti%7Cc=v6.9-12136-gf5d74f9f7c3b&ti%7Cch=f5d74f9f7c3b2495596b43c01f5747b66c8ef70d&ti%7Cgb=nvme-rx-offload-v25&ti%7Cgu=https%3A%2F%2Fgithub.com%2Faaptel%2Flinux.git&ti%7Ct=aaptel