feat/platform support for hardware details #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonNet
force-pushed
the
feat/platform-support-for-hardware-details
branch
from
8023b0c to
d43dbb1
Compare
Use the database type for it, it was breaking when fetching hardwares that had that version
WilsonNet
force-pushed
the
feat/platform-support-for-hardware-details
branch
from
d43dbb1 to
378f588
Compare
MarceloRobert
approved these changes
Feb 4, 2025
| @@ -94,7 +96,7 @@ class HardwareTestHistoryItem(TestHistoryItem): | |||
| class HardwareBuildHistoryItem(BuildHistoryItem): | |||
| tree_name: Optional[str] | |||
| issue_id: Optional[str] | |||
| issue_version: Optional[int] | |||
| issue_version: Optional[Issue__Version] | |||
There was a problem hiding this comment.
nit: I don't see a need to change this here, unless you change other fields as well, but it will work nonetheless
There was a problem hiding this comment.
I have the opinion that in this case specifically (moving to the standardized types) any gradual change is already good. But I agree that if this change was not motivated by any other thing other than simply changing the type, I'd like to see this happen at least in every field of this model
murilx
approved these changes
Feb 4, 2025
- Added `models.Q` to filter queries by `environment_misc__platform` - Wrapped `_sanitize_records` and `_format_processing_for_response` in try block - Updated error response to use `e.json()` in `HardwareDetailsSummaryView` - Added check for `summaryResponse.data.common.compatibles` length in `HardwareDetails.tsx`
WilsonNet
force-pushed
the
feat/platform-support-for-hardware-details
branch
from
378f588 to
ac8eadb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes Hardware comaptible with the platform field in the JSON.
Closes #865
How to test
Use known platforms that are not compatibles:
http://localhost:5173/hardware/kubernetes?et=1738672200&st=1738240200
http://localhost:5173/hardware/sc7180-trogdor-lazor-limozeen?et=1738672200&st=1738240200
http://localhost:5173/hardware/acer-chromebox-cxi4-puff?et=1738672200&st=1738240200