Refactor directory structure and Makefile & update deps #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tekenstam
commented
Oct 25, 2023
•
tekenstam
commented
- Align with Kubebuilder v3
- Update to ginkgo v2
- Update to Go 1.21
- Update client-go to v0.28.3
- Update controller-runtime to v0.16.3
Align with Kubebuilder v3 Signed-off-by: Todd Ekenstam <Todd_Ekenstam@intuit.com>
Signed-off-by: Todd Ekenstam <Todd_Ekenstam@intuit.com>
Signed-off-by: Todd Ekenstam <Todd_Ekenstam@intuit.com>
Signed-off-by: Todd Ekenstam <Todd_Ekenstam@intuit.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 66.52% 66.34% -0.18%
==========================================
Files 3 3
Lines 1141 1141
==========================================
- Hits 759 757 -2
- Misses 303 306 +3
+ Partials 79 78 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Todd Ekenstam <Todd_Ekenstam@intuit.com>
tekenstam
changed the title
RaviHari
approved these changes
Oct 25, 2023
figo
approved these changes
Oct 25, 2023
ZihanJiang96
approved these changes
Oct 25, 2023
vgunapati
approved these changes
Oct 25, 2023
kevdowney
approved these changes
Oct 30, 2023
navinjoy
reviewed
Jan 3, 2024
|
|
||
| mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{ | ||
| Scheme: scheme, | ||
| // Metrics: metricsserver.Options{BindAddress: metricsAddr}, |
navinjoy
reviewed
Jan 3, 2024
| sigs.k8s.io/controller-runtime v0.13.1 | ||
| k8s.io/api v0.28.3 | ||
| k8s.io/apimachinery v0.28.3 | ||
| k8s.io/client-go v0.28.3 |
There was a problem hiding this comment.
@tekenstam should we upgrade to 0.26.x instead? to be compatible with k8s 1.26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.