Merge pull request #1348 from keboola/vb-fix-client

FIX client method for refresh-tables-information in bucket
keboola · Jun 6, 2024 · 2a232b5 · 2a232b5
2 parents a331eca + f79aa43
commit 2a232b5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/Keboola/StorageApi/Client.php b/src/Keboola/StorageApi/Client.php
@@ -479,9 +479,9 @@ public function refreshBucket(string $bucketId)
      *      error?: array{code: string|null, message: string|null, exceptionId: string|null}
      *  }
      */
-    public function refreshTableInformationInBucket(int $branchId, string $bucketId)
+    public function refreshTableInformationInBucket(string $bucketId)
     {
-        $url = sprintf('branch/%s/buckets/%s/refresh-tables-info', $branchId, $bucketId);
+        $url = sprintf('buckets/%s/refresh-tables-info', $bucketId);
 
         return $this->apiPostJson($url);
     }

diff --git a/tests/Backend/ExternalBuckets/SnowflakeBucketsRefreshTablesInformationTest.php b/tests/Backend/ExternalBuckets/SnowflakeBucketsRefreshTablesInformationTest.php
@@ -6,9 +6,7 @@
 
 use Keboola\StorageApi\Workspaces;
 use Keboola\TableBackendUtils\Escaping\Snowflake\SnowflakeQuote;
-use Keboola\Test\Backend\Workspaces\Backend\WorkspaceBackendFactory;
 use Keboola\Test\Utils\ConnectionUtils;
-use Throwable;
 
 class SnowflakeBucketsRefreshTablesInformationTest extends BaseExternalBuckets
 {
@@ -19,7 +17,8 @@ public function testRefreshTablesInformationEndpointExists(): void
         $bucketId = $this->initEmptyBucketWithDescription(self::STAGE_IN);
         $bucket = $this->_client->getBucket($bucketId);
 
-        $this->_client->refreshTableInformationInBucket($bucket['idBranch'], $bucketId);
+        $bClient = $this->getBranchAwareDefaultClient($bucket['idBranch']);
+        $bClient->refreshTableInformationInBucket($bucketId);
         $this->assertTrue(true, 'Testing only if requests working.');
 
         $this->dropBucketIfExists($this->_client, $bucketId);
@@ -73,9 +72,11 @@ public function testRefreshTablesInformation(): void
             ),
         );
 
-        $jobInfo = $this->_client->refreshTableInformationInBucket($bucket['idBranch'], $bucketId);
+        $bClient = $this->getBranchAwareDefaultClient($bucket['idBranch']);
 
-        $this->_client->waitForJob($jobInfo['id']);
+        $jobInfo = $bClient->refreshTableInformationInBucket($bucketId);
+
+        $bClient->waitForJob($jobInfo['id']);
 
         $refreshedTable = $this->_client->getTable($tableId);