fixing tcflow and constants #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Linunx values I've seen are not powers of 2 from 4-32 but consecutive from 0-3, at least for Fedora, Debian, and Ubuntu.
|
Can you provide a source? I’ve modified these values a lot but I unfortunately didn’t keep track of where I got them from. It’d be nice to get the right values that work everywhere. |
|
Good point -- I don't see a reliable way. If the known possibilities for Linux are [0,1,2,3] and [16, 32, 4,8], what about probing for the correct values for the current host? Just pushed code that probes. (the source of the current values, btw is Fedora on my laptop, a dreamhost Debian 9.2 machine, and the current version of Ubuntu) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux values I've seen are not powers of 2 from 4-32 but
consecutive from 0-3, at least for Fedora, Debian, and Ubuntu.