enabled uncontrolled/un-controlled open behaviour for DatePicker
#4500
+529
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b93b9e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mark-tate
force-pushed
the
open-interactions
branch
from
c966b4f to
f86f05b
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
f86f05b to
566414a
Compare
mark-tate
force-pushed
the
open-interactions
branch
2 times, most recently
from
bce766b to
17242e8
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
17242e8 to
6508d4e
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
6508d4e to
32e73ab
Compare
mark-tate
added
the
chromatic
github-actions
bot
removed
the
chromatic
mark-tate
force-pushed
the
open-interactions
branch
from
da8186f to
882b2e2
Compare
joshwooding
reviewed
Dec 17, 2024
mark-tate
force-pushed
the
open-interactions
branch
2 times, most recently
from
3cea7c6 to
1ed601d
Compare
mark-tate
added
the
chromatic
github-actions
bot
removed
the
chromatic
mark-tate
added
the
chromatic
mark-tate
force-pushed
the
open-interactions
branch
from
5d0a456 to
75bbd62
Compare
mark-tate
force-pushed
the
open-interactions
branch
2 times, most recently
from
6c2dce1 to
0d4e04d
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
0d4e04d to
68f91b6
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
68f91b6 to
5a2626c
Compare
- added `openOnClick`, `openOnKeyDown` and `openOnFocus` props to `DatePicker`. - revise the controlled behaviour of the `open` prop on `DatePickerOverlay`. - add examples for controlled and uncontrolled behaviour.
mark-tate
force-pushed
the
open-interactions
branch
from
5a2626c to
5554f34
Compare
mark-tate
force-pushed
the
open-interactions
branch
from
5554f34 to
bcaab28
Compare
- `openOnClick` will keep the input focused - arrow key down will move focus to the calendar
mark-tate
force-pushed
the
open-interactions
branch
from
bcaab28 to
8edf5fc
Compare
alexmotoc
reviewed
Feb 4, 2025
alexmotoc
reviewed
Feb 4, 2025
mark-tate
added
the
chromatic
github-actions
bot
removed
the
chromatic
|
@jake-costa final chance for a review of your feedback before we push this. |
jake-costa
reviewed
Feb 12, 2025
There was a problem hiding this comment.
@mark-tate The openOnClick and open on down arrow key press functionality is working. But I did notice the experimental time example also displays the datepicker when arrow down is pressed when focus is in the time spinbutton selector.
For the remaining a11y issues, is issue #4096 the one for the future a11y iteration that is planned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openOnClickprop toDatePicker.openprop onDatePickerOverlay.