Skip to content

Commit

Permalink
Update readme
Browse files Browse the repository at this point in the history
  • Loading branch information
jjos2372 authored May 18, 2020
1 parent 97fddd1 commit 7553c83
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ All return values for functions should be checked in every function.

## Key Derivation Algorithm

All Burst wallets up to now derive the private based on a [SHA-256 of the passphrase]
(https://github.com/burst-apps-team/burstkit4j/blob/c87793a4b76cc881f6596283a5bdbbc3ff1dde58/burstKit/src/main/java/burst/kit/crypto/BurstCryptoImpl.java#L125).
All Burst wallets up to now derive the private based on a [SHA-256 of the passphrase](https://github.com/burst-apps-team/burstkit4j/blob/c87793a4b76cc881f6596283a5bdbbc3ff1dde58/burstKit/src/main/java/burst/kit/crypto/BurstCryptoImpl.java#L125).
This is not how BIP32 wallets work, thus you will not be able to use your ledger *recovery phrase* directly on *legacy* Burst wallets, **only using another BIP32 device**.

Burst is a registered [BIP-0044 coin](https://github.com/satoshilabs/slips/blob/master/slip-0044.md) with type equals `30` or `0x8000001e`.
Expand All @@ -127,8 +126,7 @@ the `index` for identifying different accounts (addresses).
## Signatures

Burst signatures are not supported natively by Ledger.
So the [Curve25519 Burst signature]
(https://github.com/burst-apps-team/burstkit4j/blob/c87793a4b76cc881f6596283a5bdbbc3ff1dde58/burstKit/src/main/java/burst/kit/crypto/ec/Curve25519Impl.java#L35) was implemented on this Ledger App.
So the [Curve25519 Burst signature](https://github.com/burst-apps-team/burstkit4j/blob/c87793a4b76cc881f6596283a5bdbbc3ff1dde58/burstKit/src/main/java/burst/kit/crypto/ec/Curve25519Impl.java#L35) was implemented on this Ledger App.


## License
Expand All @@ -141,4 +139,4 @@ jjos

Donation address: BURST-JJQS-MMA4-GHB4-4ZNZU

(Initially forked from [app-ledger-ardor](https://github.com/jelurida-dev/app-ledger-ardor-main).)
(Initially forked from [app-ledger-ardor](https://github.com/jelurida-dev/app-ledger-ardor-main).)

0 comments on commit 7553c83

Please sign in to comment.