Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rootless containers #2029
base: master
Are you sure you want to change the base?
feat: Rootless containers #2029
Changes from all commits
e7e200a
29a9a3b
e91e6c3
04c9c04
60a8be1
81be54a
bd07ace
c33199f
a2611bd
0fcf9c4
fb186c6
4ed8899
96281c8
3f98d7b
a33c106
ac0c8f1
c1d97c3
48629c8
ae5d123
b2e00fb
40a990a
1021067
4f2e958
724be69
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased my branch before creating PR to not conflict with master. This comes from the master branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you need to rebase again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and nothing is updated.
I think it is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, can you simply drop the commit when rebasing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?
It is already rebased and the changes on master (during the PR development) are applied to my branch. PR should be mergable without any problem, I think. What am I missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you rebase the branch with current master the commit shouldn't show up. I will want to squash-merge this, and I want to limit the chance for conflicts, that's all :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I still didn't understand.
I synchronized my cloned repo with the official repo. Their master are the same.
Then I rebased my branch with the current master. This is what I get at the end.
I didn't add
JICOFO_ENABLE_ICE_FAILURE_DETECTION
line manually. It came from the previous rebase. And if I rebase again, the command completes without any additinal changes.This file was deleted.