-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs when working with JRebel #51
base: master
Are you sure you want to change the base?
Conversation
Ignore JRebel inserted methods in getMemberRef
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
============================================
- Coverage 76.71% 75.07% -1.65%
- Complexity 105 106 +1
============================================
Files 2 2
Lines 335 345 +10
Branches 98 100 +2
============================================
+ Hits 257 259 +2
- Misses 34 40 +6
- Partials 44 46 +2
Continue to review full report at Codecov.
|
I realize this might be better if it's a configuration, so that we don't have to hardcode JRebel things that might change, instead JRebel users can configure them. Ex: // Filters methods that might be matched when resolving lambda type arguments
TypeResolver.addLambdaMemberFilter(Predicate<Member> lambdaMemberFilter) Thoughts? |
Got it. I've added the PTAL The CI failed cause by |
Ignore JRebel inserted methods in getMemberRef
Resolve issue: #50