Auto routing markdown #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a route isn't matched but the URI can match directly to a markdown file, render it directly. This allows putting arbitrary markdown files in e.g. `/foo/bar/abc.md`, `/foo/bar/def.md` and rendering them as `/foo/bar/abc.html`, `/foo/bar/def.html`. Since markdown are static content only (i.e. no template data etc.) it makes sense for them to be renderable without needing to create a view for each one.
Render appropriately-formatted errors for HTML/JSON.
Fix secret generation - overallocate length to ensure we have enough bytes. Error if no secret provided in production mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.