Skip to content

feat(ci): GitHub action for pull requests #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

timothystewart6
Copy link

@timothystewart6 timothystewart6 commented Feb 22, 2025

A simple action for pull requests that installs dependencies, transpiles TypeScript to JavaScript, and generates schemas on every pull request. Ideally this would be a great place for linting and tests however neither have bee adopted.

Depends on #22

@timothystewart6 timothystewart6 force-pushed the github-actions-pull-request branch from b9e74e0 to 61db806 Compare February 22, 2025 04:34
@timothystewart6
Copy link
Author

@Nevexo
Copy link

Nevexo commented Feb 24, 2025

Looks great! We'll likely need to change it to use the BuildJet runners, but I assume Adam or Lian will need to do that.

@timothystewart6
Copy link
Author

@Nevexo Thanks! I am unsure why it would take specialized runners considering it's just a NodeJS app and I have already been building this container on my fork without any issues.

@Nevexo
Copy link

Nevexo commented Feb 25, 2025

@Nevexo Thanks! I am unsure why it would take specialized runners considering it's just a NodeJS app and I have already been building this container on my fork without any issues.

Because BulildJet make the JetKVM 😉

@timothystewart6
Copy link
Author

timothystewart6 commented Feb 25, 2025

@Nevexo Thanks! I am unsure why it would take specialized runners considering it's just a NodeJS app and I have already been building this container on my fork without any issues.

Because BulildJet make the JetKVM 😉

Got it, I assume you mean the native piece or something else? Public runners like this would work just fine I assume as you can see above. The container is already built on my fork and is publicly accessible through GitHub. Not sure why it would take specialized, private runners to do this but maybe I am missing something 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants