feat: remove Node 16 support

jenssimon · Oct 16, 2023 · 7f040ad · 7f040ad
1 parent dc96cc1
commit 7f040ad
Show file tree

Hide file tree

Showing 3 changed files with 1,122 additions and 1,002 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,7 +12,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x, 18.x, 20.x]
+        node-version: [18.x, 20.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     steps:
@@ -24,14 +24,16 @@ jobs:
         node-version: ${{ matrix.node-version }}
         cache: 'yarn'
 
+    - name: Install dependencies
+      run: yarn
+
+    - name: Lint
+      run: yarn lint
+
     - name: Test
-      run: |
-        yarn
-        yarn ci-test
+      run: yarn test
 
     - uses: codecov/codecov-action@v3
-      with:
-        fail_ci_if_error: true
 
   release:
     needs: [build]
@@ -40,7 +42,7 @@ jobs:
         - uses: actions/checkout@v4
         - uses: actions/setup-node@v3
           with:
-            node-version: '18'
+            node-version-file: .nvmrc
             cache: 'yarn'
         - name: Release
           env:

diff --git a/package.json b/package.json
@@ -24,33 +24,29 @@
   "author": "Jens Simon <https://github.com/jenssimon>",
   "license": "MIT",
   "scripts": {
-    "lint": "eslint --fix ./",
+    "lint": "eslint ./",
     "test": "jest --coverage",
-    "ci-test": "run-s \"ci-test:*\"",
-    "ci-test:lint": "eslint ./",
-    "ci-test:test": "jest --coverage",
     "commit": "cz",
     "postinstall": "husky install",
     "prepack": "pinst --disable",
     "postpack": "pinst --enable",
     "semantic-release": "semantic-release"
   },
   "devDependencies": {
-    "@babel/core": "7.22.9",
-    "@babel/eslint-parser": "7.22.9",
-    "@commitlint/cli": "17.6.7",
-    "@commitlint/config-conventional": "17.6.7",
-    "@jenssimon/eslint-config-base": "7.1.3",
-    "@jenssimon/eslint-config-sfcc": "4.7.0",
-    "commitizen": "4.3.0",
-    "cz-conventional-changelog": "3.3.0",
-    "eslint": "8.46.0",
-    "husky": "8.0.3",
-    "jest": "29.6.2",
-    "lint-staged": "15.0.1",
-    "npm-run-all": "4.1.5",
-    "pinst": "3.0.0",
-    "semantic-release": "22.0.0"
+    "@babel/core": "^7.22.9",
+    "@babel/eslint-parser": "^7.22.9",
+    "@commitlint/cli": "^17.6.7",
+    "@commitlint/config-conventional": "^17.6.7",
+    "@jenssimon/eslint-config-base": "^7.1.3",
+    "@jenssimon/eslint-config-sfcc": "^4.7.0",
+    "commitizen": "^4.3.0",
+    "cz-conventional-changelog": "^3.3.0",
+    "eslint": "^8.46.0",
+    "husky": "^8.0.3",
+    "jest": "^29.6.2",
+    "lint-staged": "^15.0.1",
+    "pinst": "^3.0.0",
+    "semantic-release": "^22.0.0"
   },
   "dependencies": {
     "@babel/types": "^7.18.13",