Consume LockFileTargetLibrary for a filtered list of files the package has for a project #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e has for a project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously is a package had assets which were only for a specific TF which isn't the TF that the project uses, the converter would add an exclusion of that asset type unecessarily.
This change uses the information from nuget, in particular
LockFileTargetLibrary, to get a filtered view of the assets specific to what the project would actually consume.The only hack is with analyzers, which aren't represented in
LockFileTargetLibrary. Those aren't TF-specific anyway though, so we can use the "does the dir exist" mechanism for that.Also a minor improvement is to converge inclusions and exclusions to "All" if they match everything the package contains. ie if the flags was going to be "Compile, Runtime" but that package only had those assets (no build, no analyzers, etc), then the flags is upgraded to "All".