Add include/ headers to pip wheel. #264
Open
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_721897385
branch
2 times, most recently
from
9ff171b to
7eb0c0e
Compare
It looks like this was originally intended. But since "ml_dtypes.include" is not a python package, the headers were skipped. Adding them to the "ml_dtypes" package allows them to be included in the wheel. Also: - Bumped the version number so we can depend on the wheel that includes the headers. - Modified the pyproject.toml to load the version number directly from `ml_dtypes.__version__`. PiperOrigin-RevId: 721897385
copybara-service
bot
force-pushed
the
test_721897385
branch
from
7eb0c0e to
ccd7c32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add include/ headers to pip wheel.
It looks like this was originally intended. But since "ml_dtypes.include" is
not a python package, the headers were skipped. Adding them to the "ml_dtypes"
package allows them to be included in the wheel.
Also:
headers.
ml_dtypes.__version__.