Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

Convert Terraform to Ansible and fix several issues/RFEs #50

Merged
merged 45 commits into from
Aug 7, 2020
Merged

Convert Terraform to Ansible and fix several issues/RFEs #50

merged 45 commits into from
Aug 7, 2020

Conversation

jaredhocutt
Copy link
Owner

@jaredhocutt jaredhocutt commented Aug 6, 2020 •
edited
Loading

This is a fairly large PR that includes preliminary work needed to add air-gapped support. Most of the work here is related to removing the Terraform deployment and converting to using Ansible instead.

Along the way, several issues and RFEs were fixed.

fixes #19
fixes #38
fixes #45 - The container image is built locally and no longer pulled, so this is no longer relevant
fixes #47
fixes #48

jaredhocutt and others added 30 commits July 22, 2020 09:52
@jaredhocutt
Initial pass at adding air-gapped bundle code
3f0d6c8 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Reorganize docs into separate pages
f02552e 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Clean up docs for AWS and AWS GovCloud after split into separate docs
87eef1e 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Update RHCOS docs
6a62d56 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Add build action to CLI
43e75b9 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Add new line to beginning of prompt in container because John said so
e0566d4 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Update example variable files
bdb3f68 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Add ability to specify existing Route53 zone
ace5df3 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Specify full domain for Route53 entries
395b1da 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Fix typo in AWS and AWS GovCloud docs
7bd9bac 
Fixes #48

Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Determine RHCOS AMI for user automatically
1d785a5 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@johnsimcall
Add python netaddr to container image
84ea41e
@johnsimcall
Merge Jared's commits into my local dev-air-gapped branch
c2ececa
@johnsimcall
tolerate using RHEL8
e3a8726
@johnsimcall
first go at moving TF to Ansible
a489bd7
@johnsimcall
first crack at Route53
5a2b40a
@johnsimcall
first crack at Route53
e0f01b2
@johnsimcall
first crack at Route53
26cb22c
@johnsimcall
remove ignore_errors: from Remove Route Tables task
a08ef28
@johnsimcall
fix icmp rule to allow pings
195f5f6
@johnsimcall
remove unnecessary LB tasks
5459ad3
@johnsimcall
add security group allowance for HTTP/Ignition
d431fff
@johnsimcall
first crack at Route53
217d99e
@johnsimcall
fix user_data | leave my quotes alone
8f38f13
@johnsimcall
oops, i needed that variable
088156e
@johnsimcall
need the bootstrap node in the API and MachineConfig Groups
8662513
@johnsimcall
allow HTTP/HTTPS to the router pods
e47f9c4
@jaredhocutt
Refactor Terraform to Ansible for AWS.
11ab33d 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@johnsimcall
crude workaround for missing private DNS records
0b73047
@johnsimcall
create instances in parallel, wait until running
efe40c4
johnsimcall and others added 15 commits July 31, 2020 19:10
@johnsimcall
actually remove the private hosted zone
0b09df2
@johnsimcall
move CSR approval loop to bash script
0165114
@johnsimcall
define instance_count_workers in openshift_install role
7e3fb3e
@jaredhocutt
Remove Terraform artifacts
670a67e 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Update to work with AWS GovCloud too
fe41c63 
Aside: I hate Ansible so much sometimes. The boto library sucks.

Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@johnsimcall
remove old playbook
5596059
@jaredhocutt
Install jq
7fae85a 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Fix wording for cluster info when deploying AWS GovCloud
9cc23c2 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Fix failed when clause for destroying private DNS entries
d0ddf87 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Change the default worker type to m5.large to match docs default
a9cf450 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Update AWS and AWS GovCloud docs to document additional variables
fed7921 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Fix formatting of variable table
c28b929 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@jaredhocutt
Limit load balancer names to 32 characters
7f125db 
Signed-off-by: Jared Hocutt <jhocutt@redhat.com>
@akochnev
Fixed elb name on destroy
39dbe2b
@jaredhocutt
Merge pull request #51 from akochnev/dev-air-gapped
549d7f8 
Fixed elb name on destroy
@jaredhocutt jaredhocutt merged commit d5a226c into master Aug 7, 2020
@jaredhocutt jaredhocutt deleted the dev-terraform-to-ansible branch August 7, 2020 00:40
@jaredhocutt
Copy link
Owner Author

@akochnev Just a heads up, I merged your PR into this one and then merged this into master. When you go to look at the EIP destroy, you can go ahead and branch from master and submit the PR to merge into master.

Thanks again for the ELB PR and for taking a look at the EIP destroy.

@jaredhocutt jaredhocutt mentioned this pull request Aug 7, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jaredhocutt @johnsimcall @akochnev