-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESM and simplified config #90
Conversation
I don't know much about CommonJS and/or ESM but I made sure stuff builds - 👍 Then tested my configs still apply - 👍 But when running I notice one big problem: I can no longer open more than one viewer at a time, example:
|
Awesome, thanks!
This is strange👀 I just tried it again on mine and can't reproduce it unfortunately, for me it works. Could you try debugging it? Suggestions:
|
338780d
to
639067a
Compare
I'll suggest this on a hunch before starting to debug properly: Could it be an asynchronity thing?
Something executing out of order and stuff like that? I always make these mistakes when I deal with these. |
Ah, my fork doesn't have the Actions the same way this repo does. Lets see how I'd get the build artifact (just trying to add some debug console logs). |
Although hold on. Now is an appropriate time to check the Update: Yes, I can build using |
So I added a test console log in the |
More logging reveals it reaches
in but executes |
639067a
to
b72355a
Compare
b72355a
to
2f6fbe9
Compare
Ok! Are we ready to merge? |
This PR makes two bigger changes:
tsc
to compile to JavaScript before bundling withwebpack
because I couldn't get it to work in one go anymore (though it also seems more understandable now).js
suffixvivify-server
, making it a lot more clear and manageable, andviv
gets simplified a lot in that we no longer needjq
or anopen
/xdg-open
-command.