Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump braces from 3.0.2 to 3.0.3 #142

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jul 29, 2024

Bumps braces from 3.0.2 to 3.0.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@Tweekism
Copy link
Collaborator

Tweekism commented Jul 29, 2024

Sooo... I was pressing buttons again, and I generated a thing. I thought it would ask me some questions or confirmation or something, but noooo.

It is probably something worth looking at. However since we are not serving to the net I'd say it is not super high priority.

@jannis-baum
Copy link
Owner

jannis-baum commented Jul 29, 2024

It is probably something worth looking at. However since we are not serving to the net I'd say it is not super high priority.

Hey! @Tweekism I have already looked at this and it is in fact not relevant for us since this is only a dev dependency and doesn't even make it into the compiled version of Vivify.

A quick note on how to figure this out:

You can run yarn why <the-module>, e.g. here yarn why braces. This will tell you

yarn why v1.22.22
[1/4] 🤔  Why do we have the module "braces"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "braces@3.0.2"
info Has been hoisted to "braces"
info Reasons this module exists
   - Hoisted from "nodemon#chokidar#braces"
   - Hoisted from "@typescript-eslint#parser#@typescript-eslint#typescript-estree#globby#fast-glob#micromatch#braces"
info Disk size without dependencies: "80KB"
info Disk size with unique dependencies: "104KB"
info Disk size with transitive dependencies: "156KB"
info Number of shared dependencies: 2
=> Found "micromatch#braces@3.0.3"
info This module exists because "ts-loader#micromatch" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "96KB"
info Disk size with transitive dependencies: "148KB"
info Number of shared dependencies: 2

Notable here is the part on version 3.0.2, more specifically

   - Hoisted from "nodemon#chokidar#braces"
   - Hoisted from "@typescript-eslint#parser#@typescript-eslint#typescript-estree#globby#fast-glob#micromatch#braces"

Then you can look these (the part until the first #) up in our package.json. From there I would recommend two things

  1. Check if this is listed in dependencies or only a devDependencies. If it's the latter like in this case, we can much safer ignore this for much longer
  2. Check that there is even an updated version of that that would allow us to move to the newer version of the dependency (here braces); Otherwise just bumping it like this bot wants to will only break things. I haven't checked it again now but last time I checked there weren't any updated versions yet

To conclude, I wouldn't recommend to use these dependabot PRs since upgrading packages is more often than not more complex than just bumping the version. This will most likely break something. If you want to upgrade dependencies and/or act on dependabot alerts, please follow the steps above, and then, if applicable, upgrade the dependency manually and test that nothing broke or fix the stuff that did break :)

Copy link
Author

dependabot bot commented on behalf of github Jul 29, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/braces-3.0.3 branch July 29, 2024 05:14
@Tweekism
Copy link
Collaborator

To conclude, I wouldn't recommend to use these dependabot PRs since upgrading packages is more often than not more complex than just bumping the version. This will most likely break something.

I agree with all that, not sure under what circumstances you'd want to commit directly like that, maybe to a branch and then pull it down to test. but then you are propbably better off using yarn to do the upgrade, as they specifically say not to modify the lock file and let yarn handle it...

I just wanted to look at it, I didn't know it was going to create a PR lol

@jannis-baum
Copy link
Owner

I just wanted to look at it, I didn't know it was going to create a PR lol

Yes no worries! Just for reference, where exactly did you click for this to happen? :D

@Tweekism
Copy link
Collaborator

image

There was a button down the bottom here where i marked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants