-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump braces from 3.0.2 to 3.0.3 #142
Conversation
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Sooo... I was pressing buttons again, and I generated a thing. I thought it would ask me some questions or confirmation or something, but noooo. It is probably something worth looking at. However since we are not serving to the net I'd say it is not super high priority. |
Hey! @Tweekism I have already looked at this and it is in fact not relevant for us since this is only a dev dependency and doesn't even make it into the compiled version of Vivify. A quick note on how to figure this out: You can run
Notable here is the part on version 3.0.2, more specifically
Then you can look these (the part until the first
To conclude, I wouldn't recommend to use these dependabot PRs since upgrading packages is more often than not more complex than just bumping the version. This will most likely break something. If you want to upgrade dependencies and/or act on dependabot alerts, please follow the steps above, and then, if applicable, upgrade the dependency manually and test that nothing broke or fix the stuff that did break :) |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
I agree with all that, not sure under what circumstances you'd want to commit directly like that, maybe to a branch and then pull it down to test. but then you are propbably better off using yarn to do the upgrade, as they specifically say not to modify the lock file and let yarn handle it... I just wanted to look at it, I didn't know it was going to create a PR lol |
Yes no worries! Just for reference, where exactly did you click for this to happen? :D |
Bumps braces from 3.0.2 to 3.0.3.
Commits
74b2db2
3.0.388f1429
update eslint. lint, fix unit tests.415d660
Snyk js braces 6838727 (#40)190510f
fix tests, skip 1 test in test/braces.expand716eb9f
readme bumpa5851e5
Merge pull request #37 from coderaiser/fix/vulnerability2092bd1
feature: braces: add maxSymbols (https://github.com/micromatch/braces/issues/...9f5b4cf
fix: vulnerability (https://security.snyk.io/vuln/SNYK-JS-BRACES-6838727)98414f9
remove funding file665ab5d
update keepEscaping doc (#27)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.