Support full extended syntax

[jannis-baum]

Close #87

[jannis-baum]

Hey @tuurep I added the features that were still missing for full extended syntax support. Was super fast, the features were all added by just adding the respective plugins. I think the crux in reviewing is to check if you are okay with the stuff I wrote on the README🙈

EDIT And of course the highlight color might be a topic for u as well ^^

[tuurep]

Yeah looks great!

[tuurep]

And of course the highlight color might be a topic for u as well ^^

Inspired by seeing a PR on the iamcco repo adding the same plugin:

iamcco/markdown-preview.nvim#684

The color used in the screenshots there looks really good, and I think we could at least use the same one for light theme, and a similar for dark

What we currently have:

This is very crude and I don't like it :D

Do you agree?

However, in that PR they pretty much only added this same plugin, so I'll have to look at where the color is set, as it seems it didn't come by default with the plugin

[tuurep]

Fun fact/quirk:

Opening a new tab on a header anchor now adds a sort of 'selection' looking blue box around the element:

I'm, say, 65% sure this didn't happen before switching to using the attr plugin for this

This doesn't really matter to me but something I noticed as well.. it clears when clicking on the page

Edit:

Since I wasn't too sure, I went to double check with the current main branch. It did happen before this as well.

[jannis-baum]

This is very crude and I don't like it :D

Yes, definitely! I think the PR that you referenced didn't commit everything they had to get to that screenshot (the code also has a typo and wouldn't compile). Maybe they just added some opacity to the plain yellow?

[tuurep]

I also notice that in light theme it's the exact same color that Github has as background color in this:

So for light theme I think this is a good choice, it's #fff8c5

For the dark theme I'm not so sure. Do you have ideas?

Yellows that are dark enough look pretty much brown

Unless we flip the foreground:

Could be a different color too I guess, e.g.:

[tuurep]

Github's choice in a dark theme:

Unexpected to me 😄

Dark high contrast, where background darker, close to your theme:

[jannis-baum]

How about #ffffaf? That's the color I use for search matches e.g. in Vim and ripgrep with my color scheme Jellyfish.

I think that exact same color also works surprisingly well in light mode

What do you think?

[tuurep]

Hmm, it's pretty good

Since I imagine it's common to mark entire paragraphs and such with ====, I wanted to see how it looks like in a larger segment:

For light theme that actually looks great, here's the github mention color for comparison:

This looks ok, too. But I might even slightly prefer yours.

For dark theme...

Ouch I think it stands out too much 😄

Do you agree however?

Also a very subtle thing: the mark fg color is #000000 by default, for light theme too, so I'd set it to #1f2328 (screenshots above have this) for light, and I'm not sure about browser-specific default differences, but maybe would be most clear to explicitly set fg #000000 on dark?

[tuurep]

As a very personal take, if I was actually using the dark theme, I'd probably set it something close to this for myself:

in case that helps with decision making, but I want it to be primarily what you want 😄

[jannis-baum]

Ah nice, good idea about the paragraph. I also like the ffffaf on light and yes, dark might be slightly too strong.

I was also trying out some shades of purple and blue from my color scheme which I personally really like for the marks but I was wondering if this wouldn't be too far from the conventional yellow. What do you think?

[tuurep]

Finding it pretty impossible to find a yellow bg for dark which looks good to me, yeah I think blue/purple is a good idea and conveys the meaning just fine as well

[jannis-baum]

Actually, how about just adding some opacity? This would be the same yellow at 80% on both dark and light:

Or, if we want to use colors from the syntax highlighting for dark mode, I think these would be the best options:

1. #d7afd7
2. #d0d1fe

But I think I am slightly leaning towards keeping it simple and using the yellow at 80% for both. What's your take? After your next reply I will commit something and then merge this hahaha we're getting too deep into this :D

[tuurep]

Ok! We can keep yellow for both, I would say the 0.8 opacity is an improvement on dark, but would prefer 1.0 on light (the original #ffffaf).

we're getting too deep into this :D

Knowing myself I could tweak colors til the end of time so I do try to avoid bikeshedding but I think there was a need on this one :D

Hopefully the Github Alert colors will be easy on us

[jannis-baum]

Knowing myself I could tweak colors til the end of time so I do try to avoid bikeshedding but I think there was a need on this one :D

Haha yes, it's also nice that you put so much thought into this! Definitely helps the project

Hopefully the Github Alert colors will be easy on us