support force opus pcmu transcode #175
Conversation
lib/utils.js
Outdated
| @@ -34,7 +34,8 @@ function makeRtpEngineOpts(req, srcIsUsingSrtp, dstIsUsingSrtp, teams = false) { | |||
| 'call-id': req.get('Call-ID'), | |||
| 'replace': ['origin', 'session-connection'], | |||
| 'record call': process.env.JAMBONES_RECORD_ALL_CALLS ? 'yes' : 'no', | |||
| ...(process.env.JAMBONES_ACCEPT_G729 && { codec: { mask: 'g729', transcode: 'pcmu' } }) | |||
| ...(process.env.JAMBONES_ACCEPT_G729 && { codec: { mask: 'g729', transcode: 'pcmu' } }), | |||
There was a problem hiding this comment.
how about both JAMBONES_ACCEPT_G729 and JAMBONES_OPUS_PCMU_TRANSCODE enabled ????
There was a problem hiding this comment.
I think we still need to support JAMBONES_ACCEPT_G729 for backwards compatibility. However, we should implement also a more general solution which is a list of codecs to accept, but to transcode to PCMU/PCMA if received, e.g. "JAMBONES_ACCEPT_AND_TRANSCODE: "opus, g722"
There was a problem hiding this comment.
@davehorton just for discussion like genesys once can choose codecs setting at carrier end , this would be more generic feature and specific to carrier based on customer needs
There was a problem hiding this comment.
fixed, tested on jambonz.me
|
@davehorton we have tested this it can be merged |
|
@vdharashive have you tested with webrtc AC client, and with anchorMedia false? |
|
@davehorton anchorMedia false i have not tested since all our call have to be transcribe hence it needs to go to freeswitch |
|
for testing purposes, can you do such a test? We need to make sure the 'release media' still works with this change |
davehorton
force-pushed
the
feat/opus_pcmu_transcode
branch
from
baa146b to
033d4de
Compare
No description provided.