prepare for v1.25 as istio source is already branched #16261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faseela K <faseela.k@est.tech>
istio-testing
added
the
size/M
Signed-off-by: Faseela K <faseela.k@est.tech>
istio-testing
added
size/L
Signed-off-by: Faseela K <faseela.k@est.tech>
|
/retest |
50 tasks
bleggett
reviewed
Feb 21, 2025
| @@ -77,7 +77,7 @@ baseurl := "$(URL)" | |||
| endif | |||
|
|
|||
| # Which branch of the Istio source code do we fetch stuff from | |||
| export SOURCE_BRANCH_NAME ?= master | |||
| export SOURCE_BRANCH_NAME ?= release-1.25 | |||
There was a problem hiding this comment.
Shouldn't we leave master refs as-is? Typically we do, right?
Or is this a temporary chore we need to do, and then afterwards flip it back from release-1.25 to master?
There was a problem hiding this comment.
Yes, I think we move this back later
There was a problem hiding this comment.
There was a problem hiding this comment.
Moves back after the branch cut of istio.io happens (day .0 is released)
|
@dhawton when should this PR be merged? |
bleggett
approved these changes
Feb 21, 2025
howardjohn
approved these changes
Feb 24, 2025
dhawton
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers