systemfields: add parent community #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrcastro2
force-pushed
the
add-parent-systemfield
branch
from
eef0415 to
712a438
Compare
slint
reviewed
Feb 6, 2024
invenio_communities/communities/records/jsonschemas/communities/communities-v1.0.0.json
Outdated
Show resolved
Hide resolved
jrcastro2
force-pushed
the
add-parent-systemfield
branch
from
712a438 to
f689afc
Compare
yashlamba
reviewed
Feb 6, 2024
invenio_communities/communities/records/systemfields/parent_community.py
Outdated
Show resolved
Hide resolved
jrcastro2
force-pushed
the
add-parent-systemfield
branch
from
f689afc to
f522a50
Compare
slint
reviewed
Feb 7, 2024
There was a problem hiding this comment.
Reviewed with @0einstein0. Some minor comments on mixing service/data layers, but otherwise looks good.
Comment on lines
57
to
63
| if ( | ||
| community.access.visibility_is_public | ||
| and record.access.visibility_is_public | ||
| ): | ||
| record["parent"] = {"id": str(community.id)} | ||
| else: | ||
| raise ValueError("Parent community and child community must be public.") |
There was a problem hiding this comment.
minor: logically this would belong in the service layer, since here (in the data layer) we only care about managing the child/parent relationship in terms of data (not business rules/validation).
There was a problem hiding this comment.
I have removed it. Pinging @yashlamba as we probably want to add this check in the service layer.
invenio_communities/communities/records/systemfields/parent_community.py
Outdated
Show resolved
Hide resolved
invenio_communities/communities/records/systemfields/parent_community.py
Outdated
Show resolved
Hide resolved
invenio_communities/communities/records/systemfields/parent_community.py
Outdated
Show resolved
Hide resolved
invenio_communities/communities/records/systemfields/parent_community.py
Outdated
Show resolved
Hide resolved
invenio_communities/communities/records/systemfields/parent_community.py
Outdated
Show resolved
Hide resolved
jrcastro2
force-pushed
the
add-parent-systemfield
branch
2 times, most recently
from
141633c to
269fdfe
Compare
slint
force-pushed
the
add-parent-systemfield
branch
from
269fdfe to
efa84ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParentCommunitysystemfield zenodo/zenodo-rdm#696