administration: compare record revisions #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
force-pushed
the
compare-record-revisions
branch
2 times, most recently
from
12a8ee1 to
fc10fd5
Compare
kpsherva
reviewed
Jan 23, 2025
...p_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/administration/records/CompareRevisions.js
Outdated
Show resolved
Hide resolved
...p_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/administration/records/CompareRevisions.js
Outdated
Show resolved
Hide resolved
...p_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/administration/records/CompareRevisions.js
Show resolved
Hide resolved
zzacharo
force-pushed
the
compare-record-revisions
branch
2 times, most recently
from
f7adb3b to
6c697c2
Compare
zzacharo
force-pushed
the
compare-record-revisions
branch
2 times, most recently
from
30e7244 to
dd38008
Compare
kpsherva
reviewed
Jan 24, 2025
...p_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/administration/records/CompareRevisions.js
Outdated
Show resolved
Hide resolved
kpsherva
reviewed
Jan 24, 2025
...p_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/administration/records/CompareRevisions.js
Show resolved
Hide resolved
|
UI, general comment: what about putting the diff window inside a fluid container to take the full modal width instead of segment |
zzacharo
force-pushed
the
compare-record-revisions
branch
2 times, most recently
from
50c8ab8 to
528aa9c
Compare
jrcastro2
approved these changes
Jan 27, 2025
| this.setState({ | ||
| modalOpen: true, | ||
| modalHeader: i18next.t("Compare revisions"), | ||
| modalProps: { |
There was a problem hiding this comment.
Is this modalProps used? or just a leftover
There was a problem hiding this comment.
I updated the implementation, it was not used indeed :)
| const { error, loading, allRevisions, srcRevision, targetRevision, diff } = | ||
| this.state; | ||
|
|
||
| console.log({ diff }); |
zzacharo
force-pushed
the
compare-record-revisions
branch
from
528aa9c to
56f79da
Compare
zzacharo
force-pushed
the
compare-record-revisions
branch
from
56f79da to
6760f52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires inveniosoftware/invenio-rdm-records#1929
requires inveniosoftware/invenio-administration#233
closes #2968