[SYCL][E2E] Add selected targets to available features set #16860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
approved these changes
Jan 31, 2025
cperkinsintel
approved these changes
Jan 31, 2025
|
@intel/llvm-gatekeepers This is ready to merge. The single failure is unrelated to this pr, and is described in #16877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves two issues:
build-onlyXFAILs for target features don't trigger because the target feature is not in the available features set.any-target-isfor%ifconditions in run lines allows us to only add the bit enclosed in the condition if that target is selected. So for example if a particular target is available, but it is marked as xfail/unsupported for a given test we dont add the bits enclosed in%if target-. On the other hand if this were enclosed with%if any-target-is-, we would add it, which is not always desirable.