tests: add tests is_citeable function #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikirenz
force-pushed
the
add-test-is-citeable
branch
3 times, most recently
from
8404b28 to
2fc9ac7
Compare
|
Closes inspirehep/inspire-next#1980 |
michamos
requested changes
Mar 9, 2017
inspire_schemas/builders.py
Outdated
| def _item_has_pub_info(item): | ||
| return all( | ||
| key in item for key in ( | ||
| 'year', 'journal_title', 'journal_volume' |
There was a problem hiding this comment.
Just talked with @annetteholtkamp and year is not needed. Sorry about that.
* Moves is_citeable function outside LiteratureBuilder * Adds unit tests for the is_citeable function * Fix the logic of the is_citeable function. Now it is not considering the year anymore Signed-off-by: Riccardo Candido <riccardo.candido@gmail.com>
rikirenz
force-pushed
the
add-test-is-citeable
branch
from
2fc9ac7 to
a3ab3dd
Compare
michamos
approved these changes
Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_citeablefunction outside form the classLiteratureBuilderis_citeablefunctionSigned-off-by: Riccardo Candido riccardo.candido@gmail.com