feat: add button component #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
force-pushed
the
feature/button
branch
from
285df6a to
abacd8e
Compare
- This will allow us to standardize the button add eventually to have the possibilty to define tags/id on button for analytics
alecarn
force-pushed
the
feature/button
branch
from
abacd8e to
1759d3d
Compare
LAMM26
reviewed
Sep 6, 2024
| mat-icon-button | ||
| [color]="color()" | ||
| [disableRipple]="disableRipple()" | ||
| (click)="click.emit()" |
There was a problem hiding this comment.
ici c'est click.emit(), pour les autres c'est handleClick()
|
|
||
| @Directive() | ||
| class ButtonBase { | ||
| color = input<ButtonColor>(); |
There was a problem hiding this comment.
Est-ce que color devrait avoir une valeur par défaut, par exemple primary ou être required?
There was a problem hiding this comment.
Je ne peux pas répondre à ta question, on verra selon les besoins. Tu pourra le mettre si tu vois que c'est un besoin de toujours être à 'primary'
LAMM26
approved these changes
Sep 6, 2024
|
🎉 This PR is included in version 1.0.0-next.19 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to standardize the button and eventually to have the possibilty to define or require tags/id on button for analytics