DDIDNS-1198 prevent dependency hell by splitting go mods #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may also need to do on top of |
kd7lxl
approved these changes
Jan 23, 2025
types/go.mod
Outdated
| require ( | ||
| github.com/golang/protobuf v1.5.4 | ||
| github.com/google/go-cmp v0.6.0 | ||
| github.com/lib/pq v1.10.9 |
There was a problem hiding this comment.
Looks like this might not actually be needed:
protoc-gen-gorm/types/inet_test.go
Line 8 in 7402b54
I don't see anything in this file that would depend on pq being registered.
There was a problem hiding this comment.
you are right, I removed and re-ran tests seems fine.
Makefile
Outdated
Comment on lines
109
to
111
| cd types && go mod tidy | ||
| cd example && go mod tidy | ||
| go mod tidy |
There was a problem hiding this comment.
You can future proof this with
Suggested change
| cd types && go mod tidy | |
| cd example && go mod tidy | |
| go mod tidy | |
| find . -name go.mod -execdir go mod tidy \; |
kanaksinghal
changed the title
by splitting go mods
Thanks @chinmayb for bringing this up. I'll raise a Patch PR after this one merges. |
|
@kanaksinghal we can add a github action to check if go mod runs fine during PR |
chinmayb
approved these changes
Jan 31, 2025
kanaksinghal
added a commit
to kanaksinghal/protoc-gen-gorm
that referenced
this pull request
Jan 31, 2025
by splitting go mods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.