Next Available Address Block Support for Ansible V2 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewab
reviewed
Jan 8, 2025
Comment on lines
+754
to
+755
| cidr: 20 | ||
| next_available_id: "{{ address_block.id }}" |
There was a problem hiding this comment.
will this work, next available can only be created as a child block /20 here is not a child block of /24
There was a problem hiding this comment.
Modified address block cidr to 16
There was a problem hiding this comment.
what is {{ address_block }} and {{ ip_space }}. They haven't been put in to registers in the task above.
There was a problem hiding this comment.
Modified! aded register for ip_space and address_block
…-ansible into next-available
unasra
reviewed
Jan 13, 2025
tests/integration/targets/ipam_next_available_address_block_info/meta/main.yml
Show resolved
Hide resolved
unasra
reviewed
Jan 13, 2025
|
please add a chanelog as well |
mathewab
reviewed
Jan 15, 2025
Comment on lines
+754
to
+755
| cidr: 20 | ||
| next_available_id: "{{ address_block.id }}" |
There was a problem hiding this comment.
what is {{ address_block }} and {{ ip_space }}. They haven't been put in to registers in the task above.
mathewab
approved these changes
Jan 15, 2025
unasra
pushed a commit
to unasra/bloxone-ansible
that referenced
this pull request
Feb 4, 2025
* added code for next_available_address_block * added test cases for next_available_address_block * modified examples * added ipam_next_available_address_block.py to runtime.yml * modified cleanup.yml * addressed review comment * modified examples * modified examples * addressed review comments * addressed review comments
unasra
pushed a commit
to unasra/bloxone-ansible
that referenced
this pull request
Feb 4, 2025
* added code for next_available_address_block * added test cases for next_available_address_block * modified examples * added ipam_next_available_address_block.py to runtime.yml * modified cleanup.yml * addressed review comment * modified examples * modified examples * addressed review comments * addressed review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.