IPAM Host Support for Bloxone Ansible v2 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishrutiBuddhadev
commented
Dec 10, 2024
VishrutiBuddhadev
commented
- Generated resources for ipam_host
- Written integration tests
- deprecate b1_ipam_host and b1_ipam_host_gather
VishrutiBuddhadev
changed the title
VishrutiBuddhadev
changed the title
unasra
changed the title
unasra
reviewed
Dec 17, 2024
unasra
reviewed
Dec 19, 2024
unasra
reviewed
Jan 3, 2025
unasra
reviewed
Jan 6, 2025
|
LGTM |
mathewab
reviewed
Jan 6, 2025
mathewab
reviewed
Jan 8, 2025
mathewab
approved these changes
Jan 9, 2025
unasra
pushed a commit
to unasra/bloxone-ansible
that referenced
this pull request
Feb 4, 2025
* generated resources for ipam_host and added examples * written integration tests for ipam_host * deprecate b1_ipam_host and b1_ipam_host_gather * fixed sanity issues and added empty line at the end * removed instances of inherit * fixed documentation and added empty line at the end of file * refactored integration tests * addressed review comments * fixed sanity issues * modified examples * fixed sanity issues * addressed review comments * added new line at the end * modified examples * modified examples * added code for cleanup * addressed review comments * added new line * addressed review comments * addressed review comments --------- Co-authored-by: Ashish Mathew <54074687+mathewab@users.noreply.github.com>
unasra
pushed a commit
to unasra/bloxone-ansible
that referenced
this pull request
Feb 4, 2025
* generated resources for ipam_host and added examples * written integration tests for ipam_host * deprecate b1_ipam_host and b1_ipam_host_gather * fixed sanity issues and added empty line at the end * removed instances of inherit * fixed documentation and added empty line at the end of file * refactored integration tests * addressed review comments * fixed sanity issues * modified examples * fixed sanity issues * addressed review comments * added new line at the end * modified examples * modified examples * added code for cleanup * addressed review comments * added new line * addressed review comments * addressed review comments --------- Co-authored-by: Ashish Mathew <54074687+mathewab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.