Tsig keys Support for Bloxone Ansible v2 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unasra
reviewed
Jan 13, 2025
|
Can we add support for generat_tsig endpoint. ,where in a random Secret is generated automatically by the backend ? |
unasra
reviewed
Jan 21, 2025
unasra
reviewed
Jan 24, 2025
|
LGTM @mathewab please take a look. |
mathewab
reviewed
Jan 28, 2025
plugins/modules/tsig_key.py
Outdated
| ), | ||
| comment=dict(type="str"), | ||
| name=dict(type="str", required=True), | ||
| secret=dict(type="str", no_log=False, required=False), |
mathewab
reviewed
Jan 28, 2025
plugins/modules/tsig_key.py
Outdated
| pass # Handled by BloxoneAnsibleModule | ||
|
|
||
|
|
||
| class TsigModule(BloxoneAnsibleModule): |
There was a problem hiding this comment.
nit: should match the module name TsigKeyModule. Also applies to the Info module
There was a problem hiding this comment.
corrected and tested
mathewab
approved these changes
Jan 29, 2025
unasra
pushed a commit
to unasra/bloxone-ansible
that referenced
this pull request
Feb 4, 2025
* initial commit * fixed linter issue * fixed filter error * addressed review comments * addressed PR comment * wip * addressed Pr comments * fixed lint error * wip * addressed PR comment * linter check resolved * addressed PR comment * addressed Pr comments * addressed Pr comments
unasra
pushed a commit
to unasra/bloxone-ansible
that referenced
this pull request
Feb 4, 2025
* initial commit * fixed linter issue * fixed filter error * addressed review comments * addressed PR comment * wip * addressed Pr comments * fixed lint error * wip * addressed PR comment * linter check resolved * addressed PR comment * addressed Pr comments * addressed Pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanity check - passed
integration - passed
example - added
lint check - passed