first try at windows compatibility

[refack]

WIP for #2

[refack]

So I was stuck a bit with the pipes not closing, until i found out I need to close them on the caller side 🤦
Also I used a C++ smart string for collecting the output. If you don't want C++ that's the only thing need to refactor.
Also I left the options as TODO for today.
(P.S. I didn't see what you do with STDERR)

[refack]

Very sloppy...
Need to add some declations to dukgyp.h

obj/src/dukgyp-test.dukgyp-posix.o: In function `dukgyp_exec_cmd':
/home/travis/build/indutny/dukgyp/out/Release/../../src/dukgyp-posix.c:46: undefined reference to `dukgyp_syscall_throw'
/home/travis/build/indutny/dukgyp/out/Release/../../src/dukgyp-posix.c:51: undefined reference to `dukgyp_syscall_throw'
/home/travis/build/indutny/dukgyp/out/Release/../../src/dukgyp-posix.c:88: undefined reference to `dukgyp_close_fd'
/home/travis/build/indutny/dukgyp/out/Release/../../src/dukgyp-posix.c:89: undefined reference to `dukgyp_close_fd'
/home/travis/build/indutny/dukgyp/out/Release/../../src/dukgyp-posix.c:116: undefined reference to `dukgyp_close_fd'
/home/travis/build/indutny/dukgyp/out/Release/../../src/dukgyp-posix.c:117: undefined reference to `dukgyp_read_fd'
/home/travis/build/indutny/dukgyp/out/Release/../../src/dukgyp-posix.c:118: undefined reference to `dukgyp_close_fd'
/home/travis/build/indutny/dukgyp/out/Release/../../src/dukgyp-posix.c:127: undefined reference to `dukgyp_syscall_throw'
obj/src/dukgyp-test.dukgyp-platform.o: In function `dukgyp_native_cp_exec':
/home/travis/build/indutny/dukgyp/out/Release/../../src/dukgyp-platform.c:388: undefined reference to `dukgyp_exec_cmd'

[indutny]

No C++ allowed 😉 Will take a look tomorrow! Thanks!

[refack]

Removed c++
Merged files with #ifdef

[refack]

So I'm getting mixes results; when I build with gypkg:

D:\code\3party\dukgyp$ out\Release\dukgyp-test.exe
1..21
ok 1 Platform must be present
not ok 2 Platform must be known
ok 3 Arch must be present
ok 4 Arch must be known

and it crashes ;(

When I build with the VS2017 IDE (I run actual GYP to get vcxproj files)

D:\code\3party\dukgyp$ Default\dukgyp-test.exe        
1..21                                                 
ok 1 Platform must be present                         
not ok 2 Platform must be known                       
ok 3 Arch must be present                             
ok 4 Arch must be known                               
ok 5 cwd() must return string                         
ok 6 argv[0] must be `duktape`                        
ok 7 argv[1] must be proper                           
ok 8 fs.readdirSync() stub must return an array       
not ok 9 fs.realpathSync(random) must throw           
ok 10 fs.realpathSync() should return meaningful data 
ok 11 fs.existsSync() must return true                
ok 12 fs.existsSync() must return false               
ok 13 fs.mkdirpSync() should not throw                
ok 14 fs.writeFileSync() should not throw             
ok 15 fs.readFileSync() should return data            
ok 16 execSync() must return Buffer                   
ok 17 execSync() must return stdout                   
ok 18 execSync() must throw on non-zero exit code     
not ok 19 execSync must respect `cwd` option          
ok 20 binding.env.PATH should not be empty            
ok 21 bindings.env.rnd should be undefined            

(which is pretty good)

[indutny]

I guess something is bad with getcwd... Is there any difference in how MSVC links it?

[refack]

That's actually a code-path I did not play with, but I'll compare the build logs

[indutny]

Have you tried replacing cwd with just a function that returns string?

[refack]

P.S.

[refack]

P.P.S. I was skeptical about the whole duktapeing gyp.js, but I'm convinced. A tiny exe that kills GYP 😍

[indutny]

Thanks!

[indutny]

Would you mind if I'll pick your work from here?

[refack]

Go ahead. If you need something similar (deciphering WIN32 api), ping me.
P.S. I think the crash comes from different memory management of the result of the _strdup in line 44

• I've setup an appveyor config, you should use it it's super helpfull

[refack]

P.P.S. when working with me, don't be considerate. push/slash/refactor. I'm not afraid a good rebasing...