fix(UpdateParams/tests) Fix bugs and refine tests to ensure ‘make test’ works #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimmyExogenous
requested review from
rlan35,
adu-web3,
trestinlsd and
mikebraver
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
TimmyExogenous
changed the title
rlan35
approved these changes
Mar 4, 2024
TimmyExogenous
force-pushed
the
develop-fix-updateParam-bug
branch
from
d2e2277 to
3d1990e
Compare
TimmyExogenous
force-pushed
the
develop-fix-updateParam-bug
branch
from
3d1990e to
49edbaf
Compare
|
The failing "Protobuf / break-check" workflow can be ignored. It reminds us that some protobuf files in the withdraw module have been deleted, but these files have never been used. So, It's fine to delete them. This check won't fail after It's been merged. |
… when set parameter
use shared test utils to refine the test codes fix the problem in tests caused by denom rename
TimmyExogenous
force-pushed
the
develop-fix-updateParam-bug
branch
from
49edbaf to
3002441
Compare
MaxMustermann2
approved these changes
Mar 5, 2024
mikebraver
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we use the command line to set
ExoCoreLzAppAddress, the transaction might not be routed correctly because a repeated function is implemented in the withdraw module and the referred module name is misused. This PR deleted the repeat code related to settingExoCoreLzAppAddressin the withdraw module to fix the bug.It might be better to merge the deposit and withdrawal modules into one. This also needs to change the code related to precompiles, so we might do it in the future.
The test problem caused by token denominal renaming in the later commit has been resolved. Additionally, all tests have been refined by using a shared
BaseTestSuitedefined intestutil/util.go. Themake testcommand can be executed successfully after the second commit. In the subsequent development, we can write clean test code by referring the sharedBaseTestSuite.Todo