limit tx size for create-price, some refactor

app/ante/cosmos/sigverify.go

@@ -260,7 +260,6 @@ func OnlyLegacyAminoSigners(sigData signing.SignatureData) bool {
 
 func (svd SigVerificationDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, next sdk.AnteHandler) (newCtx sdk.Context, err error) {
 	if utils.IsOracleCreatePriceTx(tx) {
-		// TODO: verify ed25519 signature for create-price message which is signed by consensusKey
 		sigTx, ok := tx.(authsigning.SigVerifiableTx)
 		if !ok {
 			return ctx, sdkerrors.ErrTxDecode.Wrap("invalid transaction type, expected SigVerifiableTx")

app/ante/cosmos/txsize_gas.go

@@ -1,6 +1,7 @@
 package cosmos
 
 import (
+	"github.com/ExocoreNetwork/exocore/app/ante/utils"
 	anteutils "github.com/ExocoreNetwork/exocore/app/ante/utils"
 	"github.com/cosmos/cosmos-sdk/codec/legacy"
 	"github.com/cosmos/cosmos-sdk/crypto/keys/multisig"
@@ -39,6 +40,9 @@ func (cgts ConsumeTxSizeGasDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, sim
 
 	// Skip gas consumption if tx is an OracleCreatePriceTx
 	if anteutils.IsOracleCreatePriceTx(tx) {
+		if len(ctx.TxBytes()) > utils.TxSizeLimit {
+			return ctx, sdkerrors.ErrTxTooLarge.Wrapf("oracle create-price tx has exceeds size limit, limit:%d, got:%d", utils.TxSizeLimit, len(ctx.TxBytes()))
+		}
 		return next(ctx, tx, simulate)
 	}
 

app/ante/utils/oracle.go

@@ -5,18 +5,18 @@ import (
 	sdk "github.com/cosmos/cosmos-sdk/types"
 )
 
-const CreatePriceGas = 20000
+// TxSizeLimit limits max size of a create-price tx, this is calculated based on one nativeTokenbalance message of worst case(max size), which will need 576 bytes for balance update
+const TxSizeLimit = 1000
 
 func IsOracleCreatePriceTx(tx sdk.Tx) bool {
 	msgs := tx.GetMsgs()
 	if len(msgs) == 0 {
 		return false
 	}
 	for _, msg := range msgs {
-		if _, ok := msg.(*oracletypes.MsgCreatePrice); ok {
-			continue
+		if _, ok := msg.(*oracletypes.MsgCreatePrice); !ok {
+			return false
 		}
-		return false
 	}
 	return true
 }

x/oracle/keeper/nonce.go

@@ -42,9 +42,9 @@ func (k Keeper) AddNonceItem(ctx sdk.Context, nonce types.ValidatorNonce) {
 }
 
 // AddZeroNonceItemForValidators init the nonce of a specific feederID for a set of validators
-func (k Keeper) AddZeroNonceItemWithFeederIDForValidators(ctx sdk.Context, feederID uint64, valdiators []string) {
+func (k Keeper) AddZeroNonceItemWithFeederIDForValidators(ctx sdk.Context, feederID uint64, validators []string) {
 	store := prefix.NewStore(ctx.KVStore(k.storeKey), types.KeyPrefix(types.NonceKeyPrefix))
-	for _, validator := range valdiators {
+	for _, validator := range validators {
 		if n, found := k.getNonce(store, validator); found {
 			found := false
 			for _, v := range n.NonceList {

x/oracle/types/key_nonce.go

@@ -1,7 +1,7 @@
 package types
 
 const (
-	// NonceKeyPrefix is the prefix to retrieve all KeyNonce
+	// NonceKeyPrefix is used as a prefix for storing key nonces.
 	NonceKeyPrefix = "KeyNonce/value/"
 )