rewriter: switch from hardcoded --enable-dav1d_get_picture-post-condition to IA2_{PRE,POST}_CONDITION() attribute annotation macros
#510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/pre-post-condition-attribute
branch
from
154db2d to
a34c1e9
Compare
kkysen
changed the base branch from
main
to
kkysen/fix-test_runner-no-expected-signal
kkysen
force-pushed
the
kkysen/fix-test_runner-no-expected-signal
branch
from
3e27278 to
f451293
Compare
kkysen
force-pushed
the
kkysen/pre-post-condition-attribute
branch
from
a34c1e9 to
4e4b367
Compare
…ition` to `IA2_{PRE,POST}_CONDITION()` attribute annotation macros
This is much more robust and flexible
and is much closer to the end state for how this API will look.
It also makes the tests much simpler by encoding the options in the source code to be detected,
rather than needing to specify them in the CLI or hardcoded like before.
Will the full gamut of the attribute API is implemented here,
we still only support a single post-condition function,
and no pre-condition functions yet.
Those will come next.
I also tested this more thoroughly in another branch
with mostly complete multiple pre- and post-condition functions,
but that implementation is more complex,
so I wanted to put this in a separate PR.
kkysen
force-pushed
the
kkysen/fix-test_runner-no-expected-signal
branch
from
f451293 to
1d2b357
Compare
kkysen
force-pushed
the
kkysen/pre-post-condition-attribute
branch
from
4e4b367 to
1c5b9f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much more robust and flexible and is much closer to the end state for how this API will look. It also makes the tests much simpler by encoding the options in the source code to be detected, rather than needing to specify them in the CLI or hardcoded like before.
Will the full gamut of the attribute API is implemented here, we still only support a single post-condition function, and no pre-condition functions yet. Those will come next.
I also tested this more thoroughly in another branch with mostly complete multiple pre- and post-condition functions, but that implementation is more complex, so I wanted to put this in a separate PR.